[ https://issues.apache.org/jira/browse/DRILL-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254306#comment-16254306 ]
ASF GitHub Bot commented on DRILL-5962: --------------------------------------- Github user brendanstennett commented on a diff in the pull request: https://github.com/apache/drill/pull/1036#discussion_r151267136 --- Diff: contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STAsJson.java --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/* + * Wrapper for ESRI ST_AsJson to convert geometry into REST Json. + * Emulates functionality from spatial-framework-for-hadoop. + */ +package org.apache.drill.exec.expr.fn.impl.gis; + +import javax.inject.Inject; + +import org.apache.drill.exec.expr.DrillSimpleFunc; +import org.apache.drill.exec.expr.annotations.FunctionTemplate; +import org.apache.drill.exec.expr.annotations.Output; +import org.apache.drill.exec.expr.annotations.Param; +import org.apache.drill.exec.expr.holders.VarBinaryHolder; +import org.apache.drill.exec.expr.holders.VarCharHolder; + +import io.netty.buffer.DrillBuf; + +@FunctionTemplate(name = "st_as_json", scope = FunctionTemplate.FunctionScope.SIMPLE, + nulls = FunctionTemplate.NullHandling.NULL_IF_NULL) +public class STAsJson implements DrillSimpleFunc { --- End diff -- @ChrisSandison I would suggest naming this `ST_AsGeoJSON` to stay in line with the conventions set forth in PostGIS. http://www.postgis.net/docs/ST_AsGeoJSON.html > Add function STAsJSON to extend GIS support > ------------------------------------------- > > Key: DRILL-5962 > URL: https://issues.apache.org/jira/browse/DRILL-5962 > Project: Apache Drill > Issue Type: Bug > Components: Functions - Drill > Reporter: Chris Sandison > Assignee: Chris Sandison > Priority: Minor > Original Estimate: 3h > Remaining Estimate: 3h > > Add function as wrapper to ESRI's `asJson` -- This message was sent by Atlassian JIRA (v6.4.14#64029)