[
https://issues.apache.org/jira/browse/DRILL-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262714#comment-16262714
]
ASF GitHub Bot commented on DRILL-5952:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152583194
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -78,47 +78,58 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws
ValidationException, RelConv
final View view = new View(newViewName, viewSql,
newViewRelNode.getRowType(),
SchemaUtilites.getSchemaPathAsList(defaultSchema));
- validateViewCreationPossibility(drillSchema, createView, context);
+ final String schemaPath = drillSchema.getFullSchemaName();
--- End diff --
It's a good practice in Java to factor out large code pieces into separate
methods. I did this before in this class but your changes incorporated all
logic back... Maybe there is a way to keep this logic separately here and in
CreateTableHandler.class?
> Implement "CREATE TABLE IF NOT EXISTS"
> --------------------------------------
>
> Key: DRILL-5952
> URL: https://issues.apache.org/jira/browse/DRILL-5952
> Project: Apache Drill
> Issue Type: Improvement
> Components: SQL Parser
> Affects Versions: 1.11.0
> Reporter: Prasad Nagaraj Subramanya
> Assignee: Prasad Nagaraj Subramanya
> Fix For: Future
>
>
> Currently, if a table/view with the same name exists CREATE TABLE fails with
> VALIDATION ERROR
> Having "IF NOT EXISTS" support for CREATE TABLE will ensure that query
> succeeds
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
