[ 
https://issues.apache.org/jira/browse/DRILL-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264173#comment-16264173
 ] 

ASF GitHub Bot commented on DRILL-5971:
---------------------------------------

Github user vvysotskyi commented on the issue:

    https://github.com/apache/drill/pull/1049
  
    LGTM, +1. Except `INT_32` and `INT_64` parquet can contain other logical 
numeric types: `UINT_8`, `UINT_16`, `UINT_32`, `UINT_64`, `INT_8`, `INT_16`[1]. 
It would be great to add support for these logical types in this pull request 
or create another Jira for this.
    
    [1] 
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#numeric-types


> Fix INT64, INT32 logical types in complex parquet reader
> --------------------------------------------------------
>
>                 Key: DRILL-5971
>                 URL: https://issues.apache.org/jira/browse/DRILL-5971
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Parth Chandra
>            Assignee: Parth Chandra
>             Fix For: 1.12.0
>
>
> The 'complex' Parquet reader does not recognize the Parquet logical types 
> INT64, and INT32. 
> Should be a simple change to add these logical types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to