[
https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271511#comment-16271511
]
ASF GitHub Bot commented on DRILL-5993:
---------------------------------------
GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/1057
DRILL-5993 Append Row Method For VectorContainer (WIP)
## Motivation
HashJoin requires a method that can take a row from a VectorContainer and
append it to a destination VectorContainer. This is a WIP and this PR is mainly
opened to improve my understanding.
## Implementation
This is an initial implementation that works with simple VectorContainers
that are not hyper batches and do not have selection vectors. It is also
assumed that the user called **SchemaUtil.coerceContainer** on the source
VectorContainer before using the newly added **appendRow** method.
## Questions
- Do we have to worry about selection vectors in the source container?
- Do we have to think about support hyper batches in the destination
container?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/drill DRILL-5993
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1057
----
commit ee43d6808562a1ff60c17fa7622b8358b63c7276
Author: Timothy Farkas <[email protected]>
Date: 2017-11-29T20:38:41Z
- Initial Implementation of append row for a vector container
----
> Allow Copier to Copy a Record and Append to the End of an Outgoing Batch
> ------------------------------------------------------------------------
>
> Key: DRILL-5993
> URL: https://issues.apache.org/jira/browse/DRILL-5993
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> Currently the copier can only copy record from an incoming batch to the
> beginning of an outgoing batch. We need to be able to copy a record and
> append it to the end of the outgoing batch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
