[jira] [Commented] (DRILL-5851) Empty table during a join operation with a non empty table produces cast exception

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285098#comment-16285098
 ] 

ASF GitHub Bot commented on DRILL-5851:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r155938551
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
 ---
    @@ -535,4 +537,25 @@ public void close() {
         }
         super.close();
       }
    +
    +  @Override
    +  protected boolean checkForEarlyFinish() {
    +    if (joinType == JoinRelType.INNER &&
    +        (leftUpstream == IterOutcome.NONE || rightUpstream == 
IterOutcome.NONE) ||
    +        joinType != JoinRelType.INNER &&
    +        (leftUpstream == IterOutcome.NONE && rightUpstream == 
IterOutcome.NONE)) {
    +      return true;
    +    }
    +    return false;
    +  }
    +
    +  private boolean isFurtherProcessingRequired(IterOutcome upStream) {
    +    if (upStream == IterOutcome.OUT_OF_MEMORY ||
    +        upStream == IterOutcome.NONE ||
    +        upStream == IterOutcome.NOT_YET ||
    +        upStream == IterOutcome.STOP) {
    +      return false;
    +    }
    +    return true;
    --- End diff --
    
    The classic way to do this would be:
    
    ```
    return upStream == IterOutcome.OK || upStream == IterOutcome.OK_NEW_SCHEMA;
    ```
    
    That is, express the return value as a Boolean expression. Also, identify 
the states that need processing, rather than those that don't.


> Empty table during a join operation with a non empty table produces cast 
> exception 
> -----------------------------------------------------------------------------------
>
>                 Key: DRILL-5851
>                 URL: https://issues.apache.org/jira/browse/DRILL-5851
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Relational Operators
>    Affects Versions: 1.11.0
>            Reporter: Hanumath Rao Maduri
>            Assignee: Hanumath Rao Maduri
>
> Hash Join operation on tables with one table empty and the other non empty 
> throws an exception 
> {code} 
> Error: SYSTEM ERROR: DrillRuntimeException: Join only supports implicit casts 
> between 1. Numeric data
>  2. Varchar, Varbinary data 3. Date, Timestamp data Left type: VARCHAR, Right 
> type: INT. Add explicit casts to avoid this error
> {code}
> Here is an example query with which it is reproducible.
> {code}
> select * from cp.`sample-data/nation.parquet` nation left outer join 
> dfs.tmp.`2.csv` as two on two.a = nation.`N_COMMENT`;
> {code}
> the contents of 2.csv is empty (i.e not even header info).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)