[
https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288559#comment-16288559
]
ASF GitHub Bot commented on DRILL-5730:
---------------------------------------
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1045
@paul-rogers
I have split the FragmentContext into Four interfaces. We discussed 3, but
it felt like 4 was more appropriate since some methods didn't fit well in some
of the contexts.
- **ExecutorFragmentContext**: This is the highest level context that
exposes access to everything. This is used by the FragmentExecutor and is also
passed to the BatchCreators and RootCreators.
- **RootFragmentContext**: This is exposed to the root executors. It has a
few methods only needed by the root, but doesn't have access to everything like
the ExecutorFragmentContext.
- **ExchangeFragmentContext**: This contains the network functions, and is
used by the senders and recievers.
- **FragmentContext**: This is the barebones context which has no network
functions and only exposes the bare minimum needed by operators.
These contexts are interfaces that inherit each other in the following way:
ExecutorFragmentContext -> RootFragmentContext -> ExchangeFragmentContext
-> FragmentContext
There is only one implementation of the interfaces **FragmentContextImpl**.
The facade pattern is used to cast the context to the appropriate interface
depending on where it's used.
Let me know if you'd like to change the hierarchy or organization. Once we
finalize how we want to organize things I will add javadoc.
> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
> Key: DRILL-5730
> URL: https://issues.apache.org/jira/browse/DRILL-5730
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests:
> TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
> TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but
> was:<FAILED>
> Tests in error:
> TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR:
> URISyntaxExcepti...
> TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR:
> URISyn...
> TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth »
> UserRemote
> TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344
> » Rpc
> TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 »
> Rpc o...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
