[ 
https://issues.apache.org/jira/browse/DRILL-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300019#comment-16300019
 ] 

ASF GitHub Bot commented on DRILL-3993:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1066#discussion_r158259594
  
    --- Diff: 
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcPrel.java
 ---
    @@ -62,7 +62,7 @@ public JdbcPrel(RelOptCluster cluster, RelTraitSet 
traitSet, JdbcIntermediatePre
             (JavaTypeFactory) getCluster().getTypeFactory());
         final JdbcImplementor.Result result =
             jdbcImplementor.visitChild(0, input.accept(new SubsetRemover()));
    -    sql = result.asQuery().toSqlString(dialect).getSql();
    +    sql = result.asSelect().toSqlString(dialect).getSql();
    --- End diff --
    
    It is also may be another `SqlCall` instance. Thanks for pointing this, 
replaced it by `asStatement()` method.


> Rebase Drill on Calcite master branch
> -------------------------------------
>
>                 Key: DRILL-3993
>                 URL: https://issues.apache.org/jira/browse/DRILL-3993
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>    Affects Versions: 1.2.0
>            Reporter: Sudheesh Katkam
>            Assignee: Roman Kulyk
>
> Calcite keeps moving, and now we need to catch up to Calcite 1.5, and ensure 
> there are no regressions.
> Also, how do we resolve this 'catching up' issue in the long term?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to