[ https://issues.apache.org/jira/browse/DRILL-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335271#comment-16335271 ]
ASF GitHub Bot commented on DRILL-5851: --------------------------------------- Github user HanumathRao commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r163122636 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java --- @@ -136,7 +136,9 @@ public void executeProbePhase() throws SchemaChangeException { case OK_NEW_SCHEMA: if (probeBatch.getSchema().equals(probeSchema)) { doSetup(outgoingJoinBatch.getContext(), buildBatch, probeBatch, outgoingJoinBatch); - hashTable.updateBatches(); + if (hashTable != null) { + hashTable.updateBatches(); + } --- End diff -- @Ben-Zvi. Thanks Boaz for the quick review. I made the required changes and had a clean run precommit tests. Just to keep track of these failures. Here are the clean runs on the current commit. PASS (5.431 s) /root/drillAutomation/framework-master/framework/resources/Functional/schema_change_empty_batch/maprdb/binary_maprdb/emptyMaprDBLeftJoin.sql (connection: 1289554899) (queryID: 25997883-c4c3-afee-bd18-4907353109cd) PASS (6.403 s) /root/drillAutomation/framework-master/framework/resources/Functional/schema_change_empty_batch/hbase/emptyHbaseLeftJoin.sql (connection: 1037784189) (queryID: 2599792c-e9c0-304e-a82e-ff9438ed3f5b) PASS (5.392 s) /root/drillAutomation/framework-master/framework/resources/Functional/schema_change_empty_batch/hbase/emptyHbaseRightJoin.sql (connection: 1697676429) (queryID: 259979de-0f7a-f69e-9fcb-3b70f8eca3df) PASS (5.515 s) /root/drillAutomation/framework-master/framework/resources/Functional/schema_change_empty_batch/maprdb/binary_hbase/emptyMaprDBRightJoin.sql (connection: 1143786034) (queryID: 2599790d-5a7f-d737-a3dd-83baf15dcf94) > Empty table during a join operation with a non empty table produces cast > exception > ----------------------------------------------------------------------------------- > > Key: DRILL-5851 > URL: https://issues.apache.org/jira/browse/DRILL-5851 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Relational Operators > Affects Versions: 1.11.0 > Reporter: Hanumath Rao Maduri > Assignee: Hanumath Rao Maduri > Priority: Major > Fix For: 1.13.0 > > > Hash Join operation on tables with one table empty and the other non empty > throws an exception > {code} > Error: SYSTEM ERROR: DrillRuntimeException: Join only supports implicit casts > between 1. Numeric data > 2. Varchar, Varbinary data 3. Date, Timestamp data Left type: VARCHAR, Right > type: INT. Add explicit casts to avoid this error > {code} > Here is an example query with which it is reproducible. > {code} > select * from cp.`sample-data/nation.parquet` nation left outer join > dfs.tmp.`2.csv` as two on two.a = nation.`N_COMMENT`; > {code} > the contents of 2.csv is empty (i.e not even header info). -- This message was sent by Atlassian JIRA (v7.6.3#76005)