[
https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344295#comment-16344295
]
ASF GitHub Bot commented on DRILL-6032:
---------------------------------------
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1101#discussion_r164600675
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
---
@@ -805,7 +803,12 @@ private IntVector allocMetadataVector(int size, int
initialValue) {
}
@Override
- public void setMaxVarcharSize(int size) { maxVarcharSize = size; }
+ public void setKeySizes(Map<String, Integer> keySizes) {
+ Preconditions.checkNotNull(keySizes);
+
+ this.keySizes = CaseInsensitiveMap.newHashMap();
--- End diff --
Minor: Why does every hash table allocate a new map and copy its values ?
Can't all just share the keySizes map ?
> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>
> Key: DRILL-6032
> URL: https://issues.apache.org/jira/browse/DRILL-6032
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.13.0
>
>
> We need to use the RecordBatchSize to estimate the size of columns in the
> Partition batches created by HashAgg.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
