[
https://issues.apache.org/jira/browse/DRILL-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345564#comment-16345564
]
Alexander Malashevsky commented on DRILL-5919:
----------------------------------------------
*VERSION_VERIFIED:* 1.13.0-SNAPSHOT
The functionality has been verified, the following verificatios were
performed:
- Verify that
store.json.writer.allow_nan_inf/store.json.reader.allow_nan_inf are setup to
true by default - *PASSED*;
- Verify that NaN/Infinity/-Infinity values will be extracted properly
from .json file if store.json.reader.allow_nan_inf = true - *PASSED*;
- Verify that the corresponding error message will appear if to select
NaN/Infinity/-Infinity values with store.json.reader.allow_nan_inf = false -
*PASSED*;
- Verify that NaN/Infinity/-Infinity values will be written as literals
to a .json file when store.json.writer.allow_nan_inf = true - *PASSED*;
- Verify that NaN/Infinity/-Infinity values will be written as string
values to a .json file when store.json.writer.allow_nan_inf = false - *PASSED*;
- Verify that NaN/Infinity/-Infinity values are processed properly in
queries with UNION, UNION ALL, JOIN, ORDER BY, WHERE, GROUP BY etc. - 2 issues
found -> DRILL-6121, DRILL-6122
- Verify convert_toJSON/convert_fromJSON functions - *PASSED*;
- Verify that NaN/Infinity/-Infinity values will be processed properly
by Math functions - 1 issue found -> DRILL-6120
> Add non-numeric support for JSON processing
> -------------------------------------------
>
> Key: DRILL-5919
> URL: https://issues.apache.org/jira/browse/DRILL-5919
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - JSON
> Affects Versions: 1.11.0
> Reporter: Volodymyr Tkach
> Assignee: Volodymyr Tkach
> Priority: Major
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.13.0
>
>
> Add session options to allow drill working with non standard json strings
> number literals like: NaN, Infinity, -Infinity. By default these options will
> be switched off, the user will be able to toggle them during working session.
> *For documentation*
> 1. Added two session options {{store.json.reader.allow_nan_inf}} and
> {{store.json.writer.allow_nan_inf}} that allow to read/write NaN and Infinity
> as numbers. By default these options are set to true.
> 2. Extended signature of {{convert_toJSON}} and {{convert_fromJSON}}
> functions by adding second optional parameter that enables read/write NaN and
> Infinity.
> For example:
> {noformat}
> select convert_fromJSON('{"key": NaN}') from (values(1)); will result with
> JsonParseException, but
> select convert_fromJSON('{"key": NaN}', true) from (values(1)); will parse
> NaN as a number.
> {noformat}
> 3. Added unit tests, including tests for math functions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
