[ https://issues.apache.org/jira/browse/DRILL-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377058#comment-16377058 ]
ASF GitHub Bot commented on DRILL-6174: --------------------------------------- Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1131#discussion_r170633434 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPredicates.java --- @@ -66,6 +66,27 @@ public ParquetBooleanPredicate(String name, List<LogicalExpression> args, Expres } } + public static abstract class ParquetIsPredicate extends LogicalExpressionBase implements ParquetFilterPredicate { --- End diff -- `ParquetPredicates` class becomes too overloaded. Please split it into two: `ParquetComparisionPredicates` and `ParquetIsPredicate`. > Parquet pushdown planning improvements > -------------------------------------- > > Key: DRILL-6174 > URL: https://issues.apache.org/jira/browse/DRILL-6174 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.12.0 > Reporter: Arina Ielchiieva > Assignee: Roman Kulyk > Priority: Major > Labels: doc-impacting > Fix For: 1.13.0 > > > Currently parquet pushdown planning has certain limitations > (https://drill.apache.org/docs/parquet-filter-pushdown/). This Jira aims to > fix some of them. List of improvements can be find below: > 1. IS [NOT] NULL / TRUE / FALSE > 2. Timestamp / date / time implicit / explicit casts > {noformat} > timestamp -> date > timestamp -> varchar > date -> timestamp > date -> varchar > time -> timestamp > time -> date > time -> varchar > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)