[ 
https://issues.apache.org/jira/browse/DRILL-6021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379354#comment-16379354
 ] 

ASF GitHub Bot commented on DRILL-6021:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1127#discussion_r171075361
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java 
---
    @@ -355,14 +356,16 @@ public ClusterInfo(Collection<DrillbitInfo> drillbits,
                          boolean userEncryption,
                          boolean bitEncryption,
                          boolean shouldShowAdminInfo,
    -                     QueueInfo queueInfo) {
    +                     QueueInfo queueInfo,
    +                     boolean authEnabled ) {
    --- End diff --
    
    Please remove space after `authEnabled` and before `)`.


> Show shutdown button when authentication is not enabled
> -------------------------------------------------------
>
>                 Key: DRILL-6021
>                 URL: https://issues.apache.org/jira/browse/DRILL-6021
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.12.0
>            Reporter: Arina Ielchiieva
>            Assignee: Venkata Jyothsna Donapati
>            Priority: Major
>             Fix For: 1.13.0
>
>
> After DRILL-6017 {{shouldShowAdminInfo}} is used to decide if shutdown button 
> should be displayed on index page. But this option is set to true when 
> authentication is enabled and user is an admin. When authentication is not 
> enabled, user by default is admin. So with this fix without authentication, 
> shutdown button is absent but should be present.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to