[
https://issues.apache.org/jira/browse/DRILL-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400747#comment-16400747
]
ASF GitHub Bot commented on DRILL-6246:
---------------------------------------
GitHub user sachouche opened a pull request:
https://github.com/apache/drill/pull/1168
DRILL-6246: Reduced the size of the jdbc-all jar file
- The jdbc-all client jar has been growing in size from version to the next
(~20MB in version 1.10, ~27MB in version 1.12, and 34MB in version 1.13
- Note the exact size of the size depends on the maven profile used during
compilation (e.g., "mapr" which have more excludes)
- Originally, I tried to exclude the following calcite/avatica packages
(responsible for the recent size increase): metrics, proto, org/apache/,
com/fasterxml, com/google but some tests failed as the calcite code was
referencing some of them
- In this pull request, I have excluded the following packages:
calcite/avatica/org and calcite/avatica/metrics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachouche/drill DRILL-6246
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1168
----
commit 6b6188a6c1677595c479f67fc2e33af091c36818
Author: Salim Achouche <sachouche2@...>
Date: 2018-03-14T02:16:06Z
DRILL-6246: Reduced the size of the jdbc-all jar file
----
> Build Failing in jdbc-all artifact
> ----------------------------------
>
> Key: DRILL-6246
> URL: https://issues.apache.org/jira/browse/DRILL-6246
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.13.0
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
>
> * {color:#000000}It was noticed that the build was failing because of the
> jdbc-all artifact{color}
> * {color:#000000}The maximum compressed jar size was set to 32MB but we are
> currently creating a JAR a bit larger than 32MB {color}
> * {color:#000000}I compared apache drill-1.10.0, drill-1.12.0, and
> drill-1.13.0 (on my MacOS){color}
> * {color:#000000}jdbc-all-1.10.0 jar size: 21MB{color}
> * {color:#000000}jdbc-all-1.12.0 jar size: 27MB{color}
> * {color:#000000}jdbc-all-1.13.0 jar size: 34MB (on Linux this size is
> roughly 32MB){color}
> * {color:#000000}Compared then in more details jdbc-all-1.12.0 and
> jdbc-all-1.13.0{color}
> * {color:#000000}The bulk of the increase is attributed to the calcite
> artifact{color}
> * {color:#000000}Used to be 2MB (uncompressed) and now 22MB
> (uncompressed){color}
> * {color:#000000}It is likely an exclusion problem {color}
> * {color:#000000}The jdbc-all-1.12.0 version has only two top packages
> calcite/avatica/utils and calcite/avatica/remote{color}
> * {color:#000000}The jdbc-all-1.13.0 includes new packages (within
> calcite/avatica) metrics, proto, org/apache/, com/fasterxml, com/google{color}
> {color:#000000} {color}
> {color:#000000}I am planning to exclude these new sub-packages{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
