[
https://issues.apache.org/jira/browse/DRILL-6243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405509#comment-16405509
]
ASF GitHub Bot commented on DRILL-6243:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1169#discussion_r175598108
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -272,17 +272,19 @@
}
<#if model.shouldShowAdminInfo() || !model.isAuthEnabled()>
function shutdown(button) {
- var requestPath = "/gracefulShutdown";
- var url = getRequestUrl(requestPath);
- var result = $.ajax({
- type: 'POST',
- url: url,
- contentType : 'text/plain',
- complete: function(data) {
- alert(data.responseJSON["response"]);
- button.prop('disabled',true).css('opacity',0.5);
- }
- });
+ if (confirm("Click ok to shutdown")) {
+ var requestPath = "/gracefulShutdown";
+ var url = getRequestUrl(requestPath);
+ var result = $.ajax({
+ type: 'POST',
+ url: url,
+ contentType : 'text/plain',
+ complete: function(data) {
+ alert(data.responseJSON["response"]);
+
button.prop('disabled',true).css('opacity',0.5);
+ }
--- End diff --
please fix indentation here and below. Also add the `error: `callback for
Ajax request.
Like alert with received error ?
> Alert box to confirm shutdown of drillbit after clicking shutdown button
> -------------------------------------------------------------------------
>
> Key: DRILL-6243
> URL: https://issues.apache.org/jira/browse/DRILL-6243
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Venkata Jyothsna Donapati
> Assignee: Venkata Jyothsna Donapati
> Priority: Minor
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
