[
https://issues.apache.org/jira/browse/DRILL-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410620#comment-16410620
]
ASF GitHub Bot commented on DRILL-6280:
---------------------------------------
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1177#discussion_r176608901
--- Diff: exec/java-exec/pom.xml ---
@@ -828,31 +828,9 @@
</execution>
</executions>
</plugin>
- <plugin> <!-- classpath scanning -->
+ <plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
- <version>1.2.1</version>
- <dependencies>
- <dependency>
- <groupId>org.apache.drill</groupId>
- <artifactId>drill-common</artifactId>
- <version>${project.version}</version>
- <classifier>tests</classifier>
- </dependency>
- </dependencies>
- <executions>
- <execution>
- <phase>process-classes</phase>
- <goals><goal>java</goal></goals>
- </execution>
- </executions>
- <configuration>
-
<mainClass>org.apache.drill.common.scanner.BuildTimeScan</mainClass>
- <includePluginDependencies>true</includePluginDependencies>
--- End diff --
This is a nice move.
I asked about `<includePluginDependencies>`, but you have already answered
above, we just use project dependencies for now.
> Cleanup execution of BuildTimeScan during maven build
> -----------------------------------------------------
>
> Key: DRILL-6280
> URL: https://issues.apache.org/jira/browse/DRILL-6280
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
>
> {{exec:java}} has a dependency on {{logback-classic}} that is only available
> in {{test}} scope.
> {noformat}
> [INFO] --- exec-maven-plugin:1.2.1:java (default) @ drill-common ---
> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
> SLF4J: Defaulting to no-operation (NOP) logger implementation
> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
> details.
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
