[
https://issues.apache.org/jira/browse/DRILL-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412982#comment-16412982
]
ASF GitHub Bot commented on DRILL-6278:
---------------------------------------
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1178#discussion_r176936575
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TopN/TopNBatchTest.java
---
@@ -159,7 +157,6 @@ public void priorityQueueOrderingTest() throws
Exception {
@Test
public void sortOneKeyAscending() throws Throwable {
ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
- .configProperty(ClassBuilder.CODE_DIR_OPTION,
dirTestWatcher.getDir().getAbsolutePath())
.configProperty(CodeCompiler.ENABLE_SAVE_CODE_FOR_DEBUG_TOPN, true);
--- End diff --
I think this line should be also removed since
`ENABLE_SAVE_CODE_FOR_DEBUG_TOPN` should be disabled for tests.
> DRILL-5993 Made Debugging Generated Code Harder
> -----------------------------------------------
>
> Key: DRILL-6278
> URL: https://issues.apache.org/jira/browse/DRILL-6278
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
>
> DRILL-5993 made debugging generated code more difficult since it stored
> generated code in unique directories in target. This required adding possibly
> many tmp directories as source folders in order to be able to set break
> points in generated code for different tests. This change should be reverted
> to store generated code in the original default /tmp/drill/codegen directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
