[ https://issues.apache.org/jira/browse/DRILL-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421533#comment-16421533 ]
ASF GitHub Bot commented on DRILL-6284: --------------------------------------- Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1181#discussion_r178445205 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java --- @@ -99,7 +100,23 @@ private void clear() { } } - private class FlattenMemoryManager extends AbstractRecordBatchMemoryManager { + public enum Metric implements MetricDef { + INPUT_BATCH_COUNT, + AVG_INPUT_BATCH_BYTES, + AVG_INPUT_ROW_BYTES, + TOTAL_INPUT_RECORDS, + OUTPUT_BATCH_COUNT, + AVG_OUTPUT_BATCH_BYTES, + AVG_OUTPUT_ROW_BYTES, + TOTAL_OUTPUT_RECORDS; --- End diff -- Very nice, these labels should be quite readable in the UI. (We should have an enum-to-label lookup table, but we don't...) This pass I noticed the inconsistency between `INPUT_BATCH_COUNT` and `TOTAL_INPUT_RECORDS`. Perhaps change the latter to `INPUT_RECORD_COUNT`. > Add operator metrics for batch sizing for flatten > ------------------------------------------------- > > Key: DRILL-6284 > URL: https://issues.apache.org/jira/browse/DRILL-6284 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Flow > Affects Versions: 1.13.0 > Reporter: Padma Penumarthy > Assignee: Padma Penumarthy > Priority: Critical > Fix For: 1.14.0 > > > Add the following operator metrics for flatten. > NUM_INCOMING_BATCHES, > AVG_INPUT_BATCH_SIZE, > AVG_INPUT_ROW_WIDTH, > TOTAL_INPUT_RECORDS, > NUM_OUTGOING_BATCHES, > AVG_OUTPUT_BATCH_SIZE, > AVG_OUTPUT_ROW_WIDTH, > TOTAL_OUTPUT_RECORDS; > -- This message was sent by Atlassian JIRA (v7.6.3#76005)