[ 
https://issues.apache.org/jira/browse/DRILL-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431106#comment-16431106
 ] 

ASF GitHub Bot commented on DRILL-6311:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1202#discussion_r180205787
  
    --- Diff: exec/vector/pom.xml ---
    @@ -69,6 +69,7 @@
           <groupId>org.apache.drill</groupId>
           <artifactId>drill-common</artifactId>
           <version>${project.version}</version>
    +      <scope>test</scope>
    --- End diff --
    
    @vrozov JUnit supports including or excluding tests based on categories. 
Categories are just marker interfaces that are passed to the `@Category` 
annotation. For example a test class annotated with `@Category(SlowTest.Class)` 
will be excluded from a Travis run since Travis excludes the SlowTest category. 
All the test categories needed to be included in a common artifact since all 
the drill submodules require the test categories. So the test categories were 
added to drill-common. 
    
    If drill-common is not included mvn would fail with an error when running 
tests marked with `@Category(SlowTest.class)` since JUnit would not be able to 
find the SlowTest class.


> No logging information in drillbit.log / drillbit.out
> -----------------------------------------------------
>
>                 Key: DRILL-6311
>                 URL: https://issues.apache.org/jira/browse/DRILL-6311
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>    Affects Versions: 1.14.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>            Priority: Major
>             Fix For: 1.14.0
>
>
> On latest masterĀ 9a6cb59b9b7a5b127e5f60309ce2f506ede9652a, when running 
> Drillbit in cluster mode, there is no log prints in drillbit.log / .out file. 
> Due to the latest commit there is a change in vector/pom.xml which is adding 
> drill-common artifact and the scope is not there. Hence it'sĀ placed under 
> drillbit jar path which also contains another logback-test.xml which 
> overrides the default logback.xml inside conf directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to