[ 
https://issues.apache.org/jira/browse/DRILL-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436558#comment-16436558
 ] 

ASF GitHub Bot commented on DRILL-6289:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1203#discussion_r181179746
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -189,11 +189,16 @@ public void run() throws Exception {
         drillbitContext.getOptionManager().init();
         javaPropertiesToSystemOptions();
         
manager.getContext().getRemoteFunctionRegistry().init(context.getConfig(), 
storeProvider, coord);
    -    registrationHandle = coord.register(md);
         webServer.start();
    -
    +    //Discovering HTTP port (in case of port hunting)
    +    if (webServer.isRunning()) {
    +      int httpPort = getWebServerPort();
    +      registrationHandle = 
coord.register(md.toBuilder().setHttpPort(httpPort).build());
    +    } else {
    +      //WebServer is not running
    +      registrationHandle = coord.register(md);
    +    }
    --- End diff --
    
    how about changing with below:
    ```
    
    if (webServer.isRunning()) {
        final int httpPort = getWebServerPort();
        md = md.toBuilder().setHttpPort(httpPort).build();
    }
    registrationHandle = coord.register(md);
    ```


> Cluster view should show more relevant information
> --------------------------------------------------
>
>                 Key: DRILL-6289
>                 URL: https://issues.apache.org/jira/browse/DRILL-6289
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.13.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> When fixing DRILL-6224, I noticed that the same information can be very 
> useful to have in the cluster view shown on a Drillbit's homepage. 
> The proposal is to show the following:
> # Heap Memory in use
> # Direct Memory (actively) in use - Since we're not able to get the total 
> memory held by Netty at the moment, but only what is currently allocated to 
> running queries
> # Process CPU
> # Average (System) Load Factor 
> Information such as the port numbers don't help much during general cluster 
> health, so it might be worth removing this information if more real-estate is 
> needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to