[ 
https://issues.apache.org/jira/browse/DRILL-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444954#comment-16444954
 ] 

ASF GitHub Bot commented on DRILL-6272:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1225#discussion_r182902184
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/FunctionInitializerTest.java
 ---
    @@ -53,17 +56,27 @@
     @Category(SqlFunctionTest.class)
     public class FunctionInitializerTest {
     
    -  private static final String CLASS_NAME = 
"com.drill.udf.CustomLowerFunction";
    +  private static final String CLASS_NAME = 
"org.apache.drill.udf.dynamic.CustomLowerFunction";
       private static URLClassLoader classLoader;
     
    +  @ClassRule
    +  public static TemporaryFolder temporaryFolder = new TemporaryFolder();
    +
       @BeforeClass
       public static void init() throws Exception {
    -    Path jars = TestTools.WORKING_PATH
    -      .resolve(TestTools.TEST_RESOURCES)
    -      .resolve("jars");
    -    String binaryName = "DrillUDF-1.0.jar";
    -    String sourceName = JarUtil.getSourceName(binaryName);
    -    URL[] urls = {jars.resolve(binaryName).toUri().toURL(), 
jars.resolve(sourceName).toUri().toURL()};
    +    String binaryName = "DrillUDF-1.0";
    +    URL template = 
ClassLoader.getSystemClassLoader().getResource("udf/dynamic/CustomLowerFunctionTemplate");
    +    assert template != null;
    --- End diff --
    
    use junit assert in unit tests.


> Remove binary jars files from source distribution
> -------------------------------------------------
>
>                 Key: DRILL-6272
>                 URL: https://issues.apache.org/jira/browse/DRILL-6272
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Vlad Rozov
>            Assignee: Arina Ielchiieva
>            Priority: Critical
>             Fix For: 1.14.0
>
>
> Per [~vrozov] the source distribution contains binary jar files under 
> exec/java-exec/src/test/resources/jars



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to