[ https://issues.apache.org/jira/browse/DRILL-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449964#comment-16449964 ]
ASF GitHub Bot commented on DRILL-6345: --------------------------------------- Github user vladimirtkach commented on a diff in the pull request: https://github.com/apache/drill/pull/1230#discussion_r183753053 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewMathFunctions.java --- @@ -116,8 +115,7 @@ public void testTrigoMathFunc() throws Throwable { @Test public void testExtendedMathFunc() throws Throwable { final BigDecimal d = new BigDecimal("100111111111111111111111111111111111.00000000000000000000000000000000000000000000000000001"); - final Object [] expected = new Object[] {Math.cbrt(1000), Math.log(10), (Math.log(64.0)/Math.log(2.0)), Math.exp(10), Math.toDegrees(0.5), Math.toRadians(45.0), Math.PI, Math.cbrt(d.doubleValue()), Math.log(d.doubleValue()), (Math.log(d.doubleValue())/Math.log(2)), Math.exp(d.doubleValue()), Math.toDegrees(d.doubleValue()), Math.toRadians(d.doubleValue())}; - + final Object [] expected = new Object[] {Math.cbrt(1000), Math.log(10), Math.log10(5), (Math.log(64.0)/Math.log(2.0)), Math.exp(10), Math.toDegrees(0.5), Math.toRadians(45.0), Math.PI, Math.cbrt(d.doubleValue()), Math.log(d.doubleValue()), (Math.log(d.doubleValue())/Math.log(2)), Math.exp(d.doubleValue()), Math.toDegrees(d.doubleValue()), Math.toRadians(d.doubleValue())}; --- End diff -- @vvysotskyi added tests with double, float, int, bigInt, uint4 types for log10 > Add LOG10 function implementation > --------------------------------- > > Key: DRILL-6345 > URL: https://issues.apache.org/jira/browse/DRILL-6345 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill > Reporter: Volodymyr Tkach > Assignee: Volodymyr Tkach > Priority: Major > Fix For: 1.14.0 > > > Add LOG10 function implementation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)