[ 
https://issues.apache.org/jira/browse/DRILL-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452807#comment-16452807
 ] 

ASF GitHub Bot commented on DRILL-6348:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1237#discussion_r184156922
  
    --- Diff: 
exec/memory/base/src/main/java/org/apache/drill/exec/memory/AllocationManager.java
 ---
    @@ -253,10 +261,12 @@ public boolean transferBalance(final BufferLedger 
target) {
               target.historicalLog.recordEvent("incoming(from %s)", 
owningLedger.allocator.name);
             }
     
    -        boolean overlimit = target.allocator.forceAllocate(size);
    +        // Release first to handle the case where the current and target 
allocators were part of the same
    +        // parent / child tree.
             allocator.releaseBytes(size);
    +        boolean allocationFit = target.allocator.forceAllocate(size);
    --- End diff --
    
    If this happens, is not there a problem that the old allocator already 
released the memory? In any case, won't runtime exception cancel the query 
anyway and all allocators will be closed.


> Unordered Receiver does not report its memory usage
> ---------------------------------------------------
>
>                 Key: DRILL-6348
>                 URL: https://issues.apache.org/jira/browse/DRILL-6348
>             Project: Apache Drill
>          Issue Type: Task
>          Components: Execution - Flow
>            Reporter: salim achouche
>            Assignee: salim achouche
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The Drill Profile functionality doesn't show any memory usage for the 
> Unordered Receiver operator. This is problematic when analyzing OOM 
> conditions since we cannot account for all of a query memory usage. This Jira 
> is to fix memory reporting for the Unordered Receiver operator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to