[ https://issues.apache.org/jira/browse/DRILL-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453195#comment-16453195 ]
ASF GitHub Bot commented on DRILL-6282: --------------------------------------- Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1189#discussion_r184223843 --- Diff: logical/pom.xml --- @@ -85,14 +85,12 @@ </dependency> <dependency> - <groupId>com.codahale.metrics</groupId> + <groupId>io.dropwizard.metrics</groupId> --- End diff -- No, it is. Thanks for catching this. Also I have noticed that `java-exec` used `io.dropwizard.metrics` as transitive from `drill-common`. For consistency I have removed `io.dropwizard.metrics` from `drill-memory-base` (it can leverage metrics from `drill-common` too). > Update Drill's Metrics dependencies > ----------------------------------- > > Key: DRILL-6282 > URL: https://issues.apache.org/jira/browse/DRILL-6282 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test > Affects Versions: 1.13.0 > Reporter: Vitalii Diravka > Assignee: Vitalii Diravka > Priority: Major > Fix For: 1.14.0 > > > There are three types of metrics in Drill: > 1. _com.yammer.metrics_, > 2. _com.codahale.metrics_, > 3. _io.dropwizard.metrics_ > Directly Drill uses only 2. The 1 and 3 ones are used as transitive > dependencies only. > The 2 and 3 ones have the same class full identifiers and maven doesn't know > which library to use ([https://github.com/dropwizard/metrics/issues/1044]). > The 2 one is an outdated, but the 3 one is still under developing and > updating. > Therefore the decision is: > * to replace com.codahale.metrics with last _io.dropwizard.metrics_ Metrics > for Drill, > * to remove _com.yammer.metrics_ dependencies. -- This message was sent by Atlassian JIRA (v7.6.3#76005)