[ 
https://issues.apache.org/jira/browse/DRILL-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460601#comment-16460601
 ] 

ASF GitHub Bot commented on DRILL-6364:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1241#discussion_r185406458
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -328,9 +432,11 @@
           //Iterates through all the nodes for update
           function reloadMetrics() {
               for (i = 1; i <= size; i++) {
    -              var address = 
$("#row-"+i).find("#address").contents().get(0).nodeValue.trim();
    -              var httpPort = 
$("#row-"+i).find("#httpPort").contents().get(0).nodeValue.trim();
    -              updateMetricsHtml(address, httpPort, i);
    +              if ( $("#row-"+i).find("#stateKey").length == 0 ) {
    +                var address = 
$("#row-"+i).find("#address").contents().get(0).nodeValue.trim();
    +                var httpPort = 
$("#row-"+i).find("#httpPort").contents().get(0).nodeValue.trim();
    +                updateMetricsHtml(address, httpPort, i);
    --- End diff --
    
    Not true please see the braces. They evaluate to different outcome.


> WebUI does not cleanly handle shutdown and state toggling when Drillbits go 
> on and offline
> ------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6364
>                 URL: https://issues.apache.org/jira/browse/DRILL-6364
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>
> When the webpage is loaded the first time, the shutdown button is enabled by 
> default, which might not be correct, since scenarios like HTTPS, etc does not 
> support this for remote bits. (i.e the user needs to navigate to that node's 
> UI for shutting it down). 
> Similarly, when a previously unseen Drillbit comes online, the node will not 
> be rendered until the page is refreshed by the user. 
> Lastly, if the node from whom the UI page was served goes down, the status 
> update for the rest of the cluster is not updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to