[
https://issues.apache.org/jira/browse/DRILL-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462715#comment-16462715
]
ASF GitHub Bot commented on DRILL-6272:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1225: DRILL-6272:
Refactor dynamic UDFs and function initializer tests to g…
URL: https://github.com/apache/drill/pull/1225#discussion_r185823774
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/FunctionInitializerTest.java
##########
@@ -45,25 +45,29 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
-import static org.mockito.Matchers.any;
-import static org.mockito.Mockito.doAnswer;
-import static org.mockito.Mockito.spy;
-@RunWith(MockitoJUnitRunner.class)
@Category(SqlFunctionTest.class)
public class FunctionInitializerTest {
- private static final String CLASS_NAME = "com.drill.udf.CustomLowerFunction";
+ @ClassRule
+ public static final TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ private static final String CLASS_NAME =
"org.apache.drill.udf.dynamic.CustomLowerFunction";
private static URLClassLoader classLoader;
@BeforeClass
public static void init() throws Exception {
- Path jars = TestTools.WORKING_PATH
- .resolve(TestTools.TEST_RESOURCES)
- .resolve("jars");
- String binaryName = "DrillUDF-1.0.jar";
- String sourceName = JarUtil.getSourceName(binaryName);
- URL[] urls = {jars.resolve(binaryName).toUri().toURL(),
jars.resolve(sourceName).toUri().toURL()};
+ File buildDirectory = temporaryFolder.getRoot();
+ String binaryName = "drill-custom-lower";
+
+ JarBuilder jarBuilder = new JarBuilder("src/test/resources/drill-udf");
+ int result = jarBuilder.build(binaryName,
buildDirectory.getAbsolutePath(), "**/CustomLowerFunction.java", null);
+ assertEquals("Build should be successful.", 0, result);
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove binary jars files from source distribution
> -------------------------------------------------
>
> Key: DRILL-6272
> URL: https://issues.apache.org/jira/browse/DRILL-6272
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vlad Rozov
> Assignee: Arina Ielchiieva
> Priority: Critical
> Fix For: 1.14.0
>
>
> Per [~vrozov] the source distribution contains binary jar files under
> exec/java-exec/src/test/resources/jars
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
