[ https://issues.apache.org/jira/browse/DRILL-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468422#comment-16468422 ]
ASF GitHub Bot commented on DRILL-6249: --------------------------------------- paul-rogers commented on a change in pull request #1251: DRILL-6249: Adding more unit testing documentation. URL: https://github.com/apache/drill/pull/1251#discussion_r186885712 ########## File path: docs/dev/MockingComponents.md ########## @@ -0,0 +1,96 @@ +# Mocking Components + +There are a few techniques for mocking classes in unit tests: + +* Use a mocking library +* Provide a simple impementation of an interface +* Build a real instance of class using the class's builders / constructors Review comment: General advice: don't mock! Use the operator fixture instead. Design code to avoid mocking. Mocking is often a strong signal that the code has unwanted dependencies that should be refactored. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Markdown Docs for Unit Testing and Link to it in README.md > -------------------------------------------------------------- > > Key: DRILL-6249 > URL: https://issues.apache.org/jira/browse/DRILL-6249 > Project: Apache Drill > Issue Type: Improvement > Reporter: Timothy Farkas > Assignee: Timothy Farkas > Priority: Major > Labels: ready-to-commit > Fix For: 1.14.0 > > > I am working on a presentation about how to use the unit testing utilities in > Drill. Instead of writing the doc and having it be lost in Google Drive > somewhere I am going to add a Markdown doc to the drill repo and link to it > in the README.md. This is appropriate since these docs will only be used by > developers, and the way we unit test will change as the code changes. So the > unit testing docs should be kept in the same repo as the code so it can be > updated and kept in sync with the rest of Drill. -- This message was sent by Atlassian JIRA (v7.6.3#76005)