[
https://issues.apache.org/jira/browse/DRILL-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480992#comment-16480992
]
ASF GitHub Bot commented on DRILL-5305:
---------------------------------------
ppadma commented on a change in pull request #1265: DRILL-5305: Query Profile
must display Query ID
URL: https://github.com/apache/drill/pull/1265#discussion_r189349466
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##########
@@ -63,7 +63,7 @@
public ProfileWrapper(final QueryProfile profile, DrillConfig drillConfig) {
this.profile = profile;
- this.id = QueryIdHelper.getQueryId(profile.getId());
+ this.id = profile.getId().hasText() ? profile.getId().getText() :
QueryIdHelper.getQueryId(profile.getId());
Review comment:
why not decode always instead of doing the check ? It is not a big deal
either way.
LGTM +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query Profile must display Query ID
> -----------------------------------
>
> Key: DRILL-5305
> URL: https://issues.apache.org/jira/browse/DRILL-5305
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - HTTP, Web Server
> Affects Versions: 1.10.0
> Reporter: Abhishek Girish
> Assignee: Kunal Khatua
> Priority: Minor
> Labels: newbie
> Fix For: 1.14.0
>
>
> It would be good to have the query ID, profile ID listed as part of the
> profile itself. Currently there is no easy way to map a profile with the
> query.
> I understand that the profile ID in the URL can be used, but often when we
> have profile dumps shared for analysis, they may not contain the query IDs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
