[
https://issues.apache.org/jira/browse/DRILL-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483249#comment-16483249
]
ASF GitHub Bot commented on DRILL-6431:
---------------------------------------
amansinha100 commented on a change in pull request #1277: DRILL-6431: Unnest
operator requires table and a single column alias
URL: https://github.com/apache/drill/pull/1277#discussion_r189745036
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/lateraljoin/TestE2EUnnestAndLateral.java
##########
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.physical.impl.lateraljoin;
+
+import org.apache.drill.test.BaseTestQuery;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import java.nio.file.Paths;
+
+import static junit.framework.TestCase.fail;
+
+public class TestE2EUnnestAndLateral extends BaseTestQuery {
+ //private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(TestE2EUnnestAndLateral.class);
Review comment:
Remove this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unnest operator requires table and a single column alias to be specified.
> -------------------------------------------------------------------------
>
> Key: DRILL-6431
> URL: https://issues.apache.org/jira/browse/DRILL-6431
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization, SQL Parser
> Reporter: Hanumath Rao Maduri
> Assignee: Hanumath Rao Maduri
> Priority: Major
> Fix For: 1.14.0
>
>
> Currently, unnest operator is not required to specify alias neither for table
> name nor column name. This has some implications on what name the unnest
> operator output column should use. One can use a common name like "unnest" as
> the output name. It means, customers need to be educated on what to expect
> from unnest operator. This might confuse some customers and also prone to
> introduce errors in the query.
> The design decision for DRILL is that unnest always produces either a scalar
> column or a map (depending upon the input schema for it), but it is always a
> single column.
> Given this scenario, it is better to enforce the requirement that unnest
> operator requires a table alias and a column alias(single column). This can
> help to disambiguate the column and further can easily be referenced in the
> query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
