[ 
https://issues.apache.org/jira/browse/DRILL-6443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488169#comment-16488169
 ] 

ASF GitHub Bot commented on DRILL-6443:
---------------------------------------

kkhatua opened a new pull request #1287: DRILL-6443: Enable Search for both 
running AND completed queries
URL: https://github.com/apache/drill/pull/1287
 
 
   When running a query in Drill, the `/profiles` page will show the search 
(and pagination) capabilities only for the top most visible table (i.e. Running 
Queries ).
   
   The _Completed Queries_ table will show the search feature only when there 
are no _Running Queries_. This is because the backend uses a generalized 
freemarker macro to define the seach capabilities for the tables being 
rendered. With running queries, both, _Running_ and _Completed_ queries tables 
have the same element ID, resulting in the search capability only being applied 
to the first table.
   
   This modifies the Freemarker macro to take an additional argument for 
distinguishing between _Running_ and _Completed_ _Queries_ tables.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Search feature for profiles is available only for running OR completed 
> queries, but not both
> --------------------------------------------------------------------------------------------
>
>                 Key: DRILL-6443
>                 URL: https://issues.apache.org/jira/browse/DRILL-6443
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.13.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> When running a query in Drill, the {{/profiles}} page will show the search 
> (and pagination) capabilities only for the top most visible table (i.e. 
> _Running Queries_ ).
> The _Completed Queries_ table will show the search feature only when there 
> are no running queries. This is because the backend uses a generalized 
> freemarker macro to define the seach capabilities for the tables being 
> rendered. With running queries, both, _running_ and _completed queries_ 
> tables have the same element ID, resulting in the search capability only 
> being applied to the first table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to