[ https://issues.apache.org/jira/browse/DRILL-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489608#comment-16489608 ]
ASF GitHub Bot commented on DRILL-6353: --------------------------------------- parthchandra commented on a change in pull request #1259: DRILL-6353: Upgrade Parquet MR dependencies URL: https://github.com/apache/drill/pull/1259#discussion_r190698166 ########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java ########## @@ -737,6 +738,7 @@ public void testBooleanPartitionPruning() throws Exception { } } + @Ignore Review comment: At what point do these tests fail? If they happen (as I suspect) during planning or building the metadata cache, then we are looking at a bigger issue that may need to be addressed before we switch to the upgraded version. Essentially, pruning checks stats to determine whether the file should be read or not. If the stats are corrupted and we use them anyway, the query will return wrong results. If the stats are not corrupted and the Parquet library refuses to read them because it cannot be sure of the state of the stats, then the pruning will fail and the query will take too long to run. If the tests are failing to execute because the Parquet library fails to read the stats, then we will have a situation where queries that used to run correctly will stop running after we upgrade to the new Parquet library, which is likely to be *very* unpopular. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Parquet MR dependencies > ------------------------------- > > Key: DRILL-6353 > URL: https://issues.apache.org/jira/browse/DRILL-6353 > Project: Apache Drill > Issue Type: Task > Reporter: Vlad Rozov > Assignee: Vlad Rozov > Priority: Major > Fix For: 1.14.0 > > > Upgrade from a custom build {{1.8.1-drill-r0}} to Apache release {{1.10.0}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)