[
https://issues.apache.org/jira/browse/DRILL-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497330#comment-16497330
]
ASF GitHub Bot commented on DRILL-6027:
---------------------------------------
Ben-Zvi commented on a change in pull request #1248: DRILL-6027: Implement
Spilling for the Hash-Join
URL: https://github.com/apache/drill/pull/1248#discussion_r192265913
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableConfig.java
##########
@@ -29,27 +29,58 @@
public class HashTableConfig {
private final int initialCapacity;
+ private final boolean initialSizeIsFinal;
private final float loadFactor;
private final List<NamedExpression> keyExprsBuild;
private final List<NamedExpression> keyExprsProbe;
private final List<Comparator> comparators;
@JsonCreator
- public HashTableConfig(@JsonProperty("initialCapacity") int initialCapacity,
@JsonProperty("loadFactor") float loadFactor,
+ public HashTableConfig(@JsonProperty("initialCapacity") int initialCapacity,
+ @JsonProperty("loadFactor") float loadFactor,
@JsonProperty("keyExprsBuild") List<NamedExpression>
keyExprsBuild,
@JsonProperty("keyExprsProbe") List<NamedExpression>
keyExprsProbe,
@JsonProperty("comparators") List<Comparator>
comparators) {
this.initialCapacity = initialCapacity;
+ this.initialSizeIsFinal = false;
this.loadFactor = loadFactor;
this.keyExprsBuild = keyExprsBuild;
this.keyExprsProbe = keyExprsProbe;
this.comparators = comparators;
}
+ @JsonCreator
+ public HashTableConfig(@JsonProperty("initialCapacity") int initialCapacity,
+ @JsonProperty("initialCapacity") boolean
initialSizeIsFinal,
Review comment:
Yes, that one looks like an error. And yes, we should reuse the "more
comprehensive" constructor. Does this work call for a special Jira, or could it
be lumped together with other expected changes ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement spill to disk for the Hash Join
> -----------------------------------------
>
> Key: DRILL-6027
> URL: https://issues.apache.org/jira/browse/DRILL-6027
> Project: Apache Drill
> Issue Type: New Feature
> Components: Execution - Relational Operators
> Affects Versions: 1.11.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
>
> Implement the spill memory to disk (as needed) feature for the Hash Join
> operator (similar to the prior work on the Hash Aggregate).
> A design draft document has been published:
> [https://docs.google.com/document/d/1-c_oGQY4E5d58qJYv_zc7ka834hSaB3wDQwqKcMoSAI/edit?usp=sharing]
> Functional spec is available:
> [https://docs.google.com/document/d/1bPAddVCRxKHxi2RjqUvISIWXNqLdbRzZT9CWmanh4h0/edit]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
