[
https://issues.apache.org/jira/browse/DRILL-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507239#comment-16507239
]
ASF GitHub Bot commented on DRILL-6476:
---------------------------------------
amansinha100 commented on a change in pull request #1308: DRILL-6476: Generate
explain plan which shows relation between Latera…
URL: https://github.com/apache/drill/pull/1308#discussion_r194243957
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/explain/NumberingRelWriter.java
##########
@@ -71,7 +76,7 @@ protected void explain_(
RelMetadataQuery mq = RelMetadataQuery.instance();
if (!mq.isVisibleInExplain(rel, detailLevel)) {
// render children in place of this, at same level
- explainInputs(inputs);
+ explainInputs(rel);
Review comment:
Did you already consider a potential alternative via the 'explainTerms()'
API ? Some operators implement it..e.g `SingleMergeExchangePrel` implement it
and the purpose is to customize what is shown in the Explain plan for that
particular relnode. My thought was this could have been cleaner way by
putting the same register/unregister logic you already have here into the
`CorrelatePrel.explainTerms(NumberingRelWriter)` method. That way you don't
have to check `instanceof` of certain specific operators in the
NumberingRelWriter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Generate explain plan which shows relation between Lateral and the
> corresponding Unnest.
> ----------------------------------------------------------------------------------------
>
> Key: DRILL-6476
> URL: https://issues.apache.org/jira/browse/DRILL-6476
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.14.0
> Reporter: Hanumath Rao Maduri
> Assignee: Hanumath Rao Maduri
> Priority: Major
>
> Currently, explain plan doesn't show that which lateral and unnest node's
> are related. This information is good to have so that the visual plan can use
> it and show the relation visually.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
