[
https://issues.apache.org/jira/browse/DRILL-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507485#comment-16507485
]
ASF GitHub Bot commented on DRILL-6373:
---------------------------------------
vrozov commented on issue #1244: DRILL-6373: Refactor Result Set Loader for
Union, List support
URL: https://github.com/apache/drill/pull/1244#issuecomment-396077437
Another issue that I noticed and that is likely related to the same changes
to `NullableValueVectors.java` is multiple attempts to add the same element to
`children` collection on different threads. Due to `Set` nature of `children`
collection only one attempt is supposed to succeed, but it is not guaranteed as
`children` is not a concurrent collection and access is not synchornized
accross threads.
```
2018-06-10 10:57:30,024
[Partitioner-24e29976-0190-774c-c213-3e59bd47533b:frag:2:1-3635] ERROR
o.a.d.exec.record.MaterializedField - Added 16923214 to 21b92297. children
fee2fd9, size 2, mod
count 2
2018-06-10 10:57:30,024
[Partitioner-24e29976-0190-774c-c213-3e59bd47533b:frag:2:1-4243] ERROR
o.a.d.exec.record.MaterializedField - Added 16923214 to 21b92297. children
fee2fd9, size 2, mod
count 2
2018-06-10 10:57:30,024
[Partitioner-24e29976-0190-774c-c213-3e59bd47533b:frag:2:1-656] ERROR
o.a.d.exec.record.MaterializedField - Added 16923214 to 21b92297. children
fee2fd9, size 3, mod
count 3
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor the Result Set Loader to prepare for Union, List support
> -----------------------------------------------------------------
>
> Key: DRILL-6373
> URL: https://issues.apache.org/jira/browse/DRILL-6373
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.13.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.14.0
>
>
> As the next step in merging the "batch sizing" enhancements, refactor the
> {{ResultSetLoader}} and related classes to prepare for Union and List
> support. This fix follows the refactoring of the column accessors for the
> same purpose. Actual Union and List support is to follow in a separate PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
