[
https://issues.apache.org/jira/browse/DRILL-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508478#comment-16508478
]
ASF GitHub Bot commented on DRILL-6477:
---------------------------------------
parthchandra commented on a change in pull request #1309: DRILL-6477: Drillbit
crashes with OOME (Heap) for a large WebUI query
URL: https://github.com/apache/drill/pull/1309#discussion_r194498399
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -204,6 +204,8 @@ private ExecConstants() {
public static final String SERVICE_KEYTAB_LOCATION = SERVICE_LOGIN_PREFIX +
".keytab";
public static final String KERBEROS_NAME_MAPPING = SERVICE_LOGIN_PREFIX +
".auth_to_local";
+ /* Provide resiliency on web server for queries submitted via HTTP */
+ public static final String HTTP_QUERY_FAIL_LOW_HEAP_THRESHOLD =
"drill.exec.http.query.fail.low_heap.threshold";
Review comment:
I would have just put this as a constant in the QueryWrapper class. I don't
expect the user to ever modify this and when the QueryWrapper is updated to
address large result sets, then we don't have to worry about removing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drillbit hangs/crashes with OOME Java Heap Space for a large query through
> WebUI
> --------------------------------------------------------------------------------
>
> Key: DRILL-6477
> URL: https://issues.apache.org/jira/browse/DRILL-6477
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.13.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.14.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> For queries submitted through the WebUI and retrieving a large resultset, the
> Drillbit often hangs or crashes due to the (foreman) Drillbit running out of
> Heap memory.
> This is because the Web client translates the resultset into a massive object
> in the heap-space and tries to send that back to the browser. This results in
> the VM thread actively trying to perform GC if the memory is not sufficient.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
