[
https://issues.apache.org/jira/browse/DRILL-5796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512704#comment-16512704
]
ASF GitHub Bot commented on DRILL-5796:
---------------------------------------
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter
pruning for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r195487510
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/stat/ParquetMetaStatCollector.java
##########
@@ -71,6 +71,26 @@ public ParquetMetaStatCollector(ParquetTableMetadataBase
parquetTableMetadata,
this.implicitColValues = implicitColValues;
}
+ /**
+ * DRILL_6259 : check if one of the fields involved in the filter is an
array.
+ * @param fields columns used in the filter.
+ * @return true if one at least is an array, false otherwise.
+ */
+ public boolean isRepeated(Set<SchemaPath> fields) {
Review comment:
I added this function to solve the issue of DRILL_6259_test_data and comply
with your comment : "Please add comment in that place in code where you fixed
issue with array, explaining this case. Since you did not add fix in a separate
commit, it's hard to tell where you made the change"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Filter pruning for multi rowgroup parquet file
> ----------------------------------------------
>
> Key: DRILL-5796
> URL: https://issues.apache.org/jira/browse/DRILL-5796
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: Damien Profeta
> Assignee: Jean-Blas IMBERT
> Priority: Major
> Fix For: 1.14.0
>
>
> Today, filter pruning use the file name as the partitioning key. This means
> you can remove a partition only if the whole file is for the same partition.
> With parquet, you can prune the filter if the rowgroup make a partition of
> your dataset as the unit of work if the rowgroup not the file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
