[
https://issues.apache.org/jira/browse/DRILL-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513116#comment-16513116
]
ASF GitHub Bot commented on DRILL-5735:
---------------------------------------
kkhatua commented on issue #1279: DRILL-5735: Allow search/sort in the Options
webUI
URL: https://github.com/apache/drill/pull/1279#issuecomment-397466246
@arina-ielchiieva / @parthchandra
Modified the PR with additional work:
1. The latest commit now carries an implementation for description in
`sys.options_val` table (DRILL-4699), making PR #536 obsolete
2. The descriptions-carrying resource file is loaded by the
`ExtendedOptionIterator` and made accessible at a class level to the
`WebServer` instance
4. The full description is to be rendered in the WebUI (i.e.
http://drillbit:8047/options )
5. The short description (if available) is shown in the System table, and
truncated with suffixing of ellipsis to indicate more content. (See bottom).
This is required so as to ensure that the formatting within SqlLine is
maintained.
```
0: jdbc:drill:drillbit=kk127.qa.lab> select * from sys.options_val where
name like 'planner.p%' or name like 'planner.width.%' or name like '%cpu%'
order by name;
+--------------------------------------------+----------+-------------------+-------+----------+--------------+-----------------------------------------------------------------------------------------------------------------+
| name | kind | accessibleScopes
| val | status | optionScope |
description |
+--------------------------------------------+----------+-------------------+-------+----------+--------------+-----------------------------------------------------------------------------------------------------------------+
| planner.cpu_load_average | FLOAT | ALL
| 0.7 | DEFAULT | BOOT |
|
| planner.parser.quoting_identifiers | VARCHAR | ALL
| ` | DEFAULT | BOOT |
|
| planner.partitioner_sender_max_threads | BIGINT | ALL
| 8 | DEFAULT | BOOT | Upper limit of threads for outbound
queuing. |
| planner.partitioner_sender_set_threads | BIGINT | ALL
| -1 | DEFAULT | BOOT | Overwrites the number of threads used to
send out batches of records. Set to -1 to disable. Typically not c... |
| planner.partitioner_sender_threads_factor | BIGINT | ALL
| 2 | DEFAULT | BOOT | A heuristic param to use to influence final
number of threads. The higher the value the fewer the number of... |
| planner.producer_consumer_queue_size | BIGINT | ALL
| 10 | DEFAULT | BOOT | How much data to prefetch from disk in
record batches out-of-band of query execution. The larger the queue ... |
| planner.width.max_per_node | BIGINT | ALL
| 0 | DEFAULT | BOOT | Max number of threads that can run in
parallel for a query on a node. |
| planner.width.max_per_query | BIGINT | ALL
| 1000 | DEFAULT | BOOT | Same as max per node but applies to the
query as executed by the entire cluster. For example, this value mi... |
+--------------------------------------------+----------+-------------------+-------+----------+--------------+-----------------------------------------------------------------------------------------------------------------+
8 rows selected (0.797 seconds)
```
6. Review comments have been addressed:
a. JavaScript is written using try-resources
b. tmpJavaScriptDir is a class instance member
c. Missing description has been added. For testing purposes, a
`planner.width.max_per_node.short` entry also exists (as shown above)
Going forward, **ALL** developers need to introduce the description of their
introduced options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> UI options grouping and filtering & Metrics hints
> -------------------------------------------------
>
> Key: DRILL-5735
> URL: https://issues.apache.org/jira/browse/DRILL-5735
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0, 1.10.0, 1.11.0
> Reporter: Muhammad Gelbana
> Assignee: Kunal Khatua
> Priority: Major
> Fix For: 1.14.0
>
>
> I'm thinking of some UI improvements that could make all the difference for
> users trying to optimize low-performing queries.
> h2. Options
> h3. Grouping
> We can organize the options to be grouped by their scope of effect, this will
> help users easily locate the options they may need to tune.
> h3. Filtering
> Since the options are a lot, we can add a filtering mechanism (i.e. string
> search or group\scope filtering) so the user can filter out the options he's
> not interested in. To provide more benefit than the grouping idea mentioned
> above, filtering may include keywords also and not just the option name,
> since the user may not be aware of the name of the option he's looking for.
> h2. Metrics
> I'm referring here to the metrics page and the query execution plan page that
> displays the overview section and major\minor fragments metrics. We can show
> hints for each metric such as:
> # What does it represent in more details.
> # What option\scope-of-options to tune (increase ? decrease ?) to improve the
> performance reported by this metric.
> # May be even provide a small dialog to quickly allow the modification of the
> related option(s) to that metric
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
