[
https://issues.apache.org/jira/browse/DRILL-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517980#comment-16517980
]
ASF GitHub Bot commented on DRILL-6454:
---------------------------------------
vdiravka commented on a change in pull request #1314: DRILL-6454: Native MapR
DB plugin support for Hive MapR-DB json table
URL: https://github.com/apache/drill/pull/1314#discussion_r196595598
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveMetadataProvider.java
##########
@@ -355,7 +355,7 @@ public LogicalInputSplit(Collection<? extends InputSplit>
inputSplits, Partition
this.partition = partition;
}
- public Collection<InputSplit> getInputSplits() {
+ public List<InputSplit> getInputSplits() {
Review comment:
There is no need to use Collection. We know exactly it is a list:
*
https://github.com/apache/drill/pull/1314/files#diff-47ddabc23de6e4245c7b2cdfa8bdb9c0R345
*
https://github.com/apache/drill/blob/master/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetScan.java#L101
Also changed usage of iterator from the last link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native MapR DB plugin support for Hive MapR-DB json table
> ---------------------------------------------------------
>
> Key: DRILL-6454
> URL: https://issues.apache.org/jira/browse/DRILL-6454
> Project: Apache Drill
> Issue Type: New Feature
> Components: Storage - Hive, Storage - MapRDB
> Affects Versions: 1.13.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
>
> Hive can create and query MapR-DB tables via maprdb-json-handler:
> https://maprdocs.mapr.com/home/Hive/ConnectingToMapR-DB.html
> The aim of this Jira to implement Drill native reader for Hive MapR-DB tables
> (similar to parquet).
> Design proposal is:
> - to use JsonTableGroupScan instead of HiveScan;
> - to add storage planning rule to convert HiveScan to MapRDBGroupScan;
> - to add system/session option to enable using of this native reader;
> - native reader can be used only for Drill build with mapr profile (there is
> no reason to leverage it for default profile);
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
