[
https://issues.apache.org/jira/browse/DRILL-6577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532816#comment-16532816
]
ASF GitHub Bot commented on DRILL-6577:
---------------------------------------
asfgit closed pull request #1359: DRILL-6577: Change Hash-Join fallback default
to false
URL: https://github.com/apache/drill/pull/1359
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/exec/java-exec/src/main/resources/drill-module.conf
b/exec/java-exec/src/main/resources/drill-module.conf
index 2e8c2e783a..14cc30d88c 100644
--- a/exec/java-exec/src/main/resources/drill-module.conf
+++ b/exec/java-exec/src/main/resources/drill-module.conf
@@ -424,7 +424,7 @@ drill.exec.options: {
# Setting to control if HashJoin should fallback to older behavior of
consuming
# unbounded memory. By default it's set to false such that the
# query will fail if there is not enough memory
- drill.exec.hashjoin.fallback.enabled: true, # should soon be changed to
false !!
+ drill.exec.hashjoin.fallback.enabled: false
# Setting to control if HashAgg should fallback to older behavior of
consuming
# unbounded memory. In case of 2 phase Agg when available memory is not
enough
# to start at least 2 partitions then HashAgg fallbacks to this case. It
can be
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Change Hash-Join default to not fallback (into pre-1.14 unlimited memory)
> -------------------------------------------------------------------------
>
> Key: DRILL-6577
> URL: https://issues.apache.org/jira/browse/DRILL-6577
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.13.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.14.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Change the default for `drill.exec.hashjoin.fallback.enabled` to *false*
> (same as for the similar Hash-Agg option). This would force users to
> calculate and assign sufficient memory for the query, or explicitly choose to
> fallback.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
