[
https://issues.apache.org/jira/browse/DRILL-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536466#comment-16536466
]
ASF GitHub Bot commented on DRILL-6346:
---------------------------------------
paul-rogers commented on a change in pull request #1348: DRILL-6346: Create an
Official Drill Docker Container
URL: https://github.com/apache/drill/pull/1348#discussion_r200860239
##########
File path: distribution/Dockerfile
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+FROM centos:7
+
+# Project version defined in pom.xml is passed as an argument
+ARG VERSION
+
+# JDK 8 is a pre-requisite to run Drill ; 'which' package is needed for
drill-config.sh
+RUN yum install -y java-1.8.0-openjdk-devel which ; yum clean all ; rm -rf
/var/cache/yum
+
+# The drill tarball is generated upon building the Drill project
+COPY target/apache-drill-$VERSION.tar.gz /tmp
+
+# Drill binaries are extracted into the '/opt/drill' directory
+RUN mkdir /opt/drill
+RUN tar -xvzf /tmp/apache-drill-$VERSION.tar.gz --directory=/opt/drill
--strip-components 1
+
+# Starts Drill in embedded mode and connects to Sqlline
+ENTRYPOINT /opt/drill/bin/drill-embedded
Review comment:
This `Dockerfile` is only for an embedded Drillbit, which is find for
playing around.
Should we also offer an example production `Dockerfile`? In such a file, the
following would also be needed:
* Copy in custom jars (UDFs custom storage plugins.)
* Copy in custom libraries (PAM, etc.)
* Specify custom config.
Doing the above will be easier if the user's files are not placed in the
`$DRILL_HOME/conf` and other directories. That is, we want to use the site
directory feature.
Maybe allow a `/opt/drill-site` location and pass `--site /opt/drill-site`
on the command line for the entry point.
Then, the `Dockerfile` can provide examples of how to copy the various kinds
of files to the proper site directory locations:
* `/opt/drill-site/` - `drill-override.conf`, `core-site.xml`, `logback.xml`
* `/opt/drill-site/jar/` - UDF and storage-plugin jars
* `/opt/drill-site/lib/` - native libraries
Note that the functionality for Drill to find things in these site directory
locations already exists. All we're doing here is showing the user how to use
them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create an Official Drill Docker Container
> -----------------------------------------
>
> Key: DRILL-6346
> URL: https://issues.apache.org/jira/browse/DRILL-6346
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Abhishek Girish
> Priority: Major
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
