[
https://issues.apache.org/jira/browse/DRILL-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537660#comment-16537660
]
ASF GitHub Bot commented on DRILL-6585:
---------------------------------------
vrozov commented on a change in pull request #1367: DRILL-6585: PartitionSender
clones vectors, but shares field metdata
URL: https://github.com/apache/drill/pull/1367#discussion_r201159333
##########
File path: exec/vector/src/main/codegen/templates/BasicTypeHelper.java
##########
@@ -233,10 +227,54 @@ public static ValueVector getNewVector(String name,
BufferAllocator allocator, M
throw new UnsupportedOperationException(buildErrorMessage("get holder
reader implementation", type, mode));
}
- public static ValueVector getNewVector(MaterializedField field,
BufferAllocator allocator){
+ public static ValueVector getNewVector(String name, BufferAllocator
allocator, MajorType type, CallBack callBack) {
+ MaterializedField field = MaterializedField.create(name, type);
+ return getNewVector(field, allocator, callBack);
+ }
+
+ public static ValueVector getNewVector(MaterializedField field,
BufferAllocator allocator) {
Review comment:
`getNewVector(MaterializedField field, ...` promotes `field` sharing between
vectors and possibly threads. What are the use cases where `MaterializedField`
needs to be shared between vectors? I mean, when is it necessary that
modifications to `MaterializedField` that belongs to one vector are reflected
transparently in another vector `MaterializedField`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> PartitionSender clones vectors, but shares field metdata
> --------------------------------------------------------
>
> Key: DRILL-6585
> URL: https://issues.apache.org/jira/browse/DRILL-6585
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
>
> See the discussion for [PR #1244 for
> DRILL-6373|https://github.com/apache/drill/pull/1244].
> The PartitionSender clones vectors. But, it does so by reusing the
> {{MaterializedField}} from the original vector. Though the original authors
> of {{MaterializedField}} apparently meant it to be immutable, later changes
> for maps and unions ended up changing it to add members.
> When cloning a map, we get the original map materialized field, then start
> doctoring it up as we add the cloned map members. This screws up the original
> map vector's metadata.
> The solution is to clone an empty version of the materialized field when
> creating a new vector.
> But, since much code creates vectors by giving a perfectly valid, unique
> materialized field, we want to add a new method for use by the ill-behaved
> uses, such as PartitionSender, that ask to create a new vector without
> cloning the materialized field.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
