[ 
https://issues.apache.org/jira/browse/DRILL-6591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543457#comment-16543457
 ] 

ASF GitHub Bot commented on DRILL-6591:
---------------------------------------

kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception 
for failed queries submitted in WebUI
URL: https://github.com/apache/drill/pull/1379#discussion_r202417597
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
 ##########
 @@ -83,12 +84,13 @@ public QueryResult run(final WorkManager workManager, 
final WebUserConnection we
     float usagePercent = getHeapUsage();
 
     // Wait until the query execution is complete or there is error submitting 
the query
-    logger.debug("Wait until the query execution is complete or there is error 
submitting the query");
+    if (logger.isDebugEnabled()) {
+      logger.debug("Wait until the query execution is complete or there is 
error submitting the query");
+    }
     do {
       try {
-        isComplete = webUserConnection.await(TimeUnit.SECONDS.toMillis(1)); 
/*periodically timeout to check heap*/
-      } catch (Exception e) { }
-
+        isComplete = 
webUserConnection.await/*timedWait*/(TimeUnit.SECONDS.toMillis(1)); 
//periodically timeout 1sec to check heap
 
 Review comment:
   My bad. That was actually a method I introduced before and reverted in the 
last commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When query fails on Web UI, result page does not show any error
> ---------------------------------------------------------------
>
>                 Key: DRILL-6591
>                 URL: https://issues.apache.org/jira/browse/DRILL-6591
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.13.0
>            Reporter: Arina Ielchiieva
>            Assignee: Kunal Khatua
>            Priority: Major
>             Fix For: 1.14.0
>
>         Attachments: no_result_found.JPG
>
>
> When query fails on Web UI result page no error is shown, only "No result 
> found." Screenshot attached. Drill should display error message instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to