[
https://issues.apache.org/jira/browse/DRILL-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543594#comment-16543594
]
ASF GitHub Bot commented on DRILL-6496:
---------------------------------------
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing
logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible
va, int[] columnWidths)
URL: https://github.com/apache/drill/pull/1336#discussion_r202443140
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/QueryTestUtil.java
##########
@@ -100,36 +96,125 @@ public static String normalizeQuery(final String query) {
}
/**
- * Execute a SQL query, and print the results.
+ * Execute a SQL query, and output the results.
*
* @param drillClient drill client to use
* @param type type of the query
* @param queryString query string
+ * @param print True to output results to stdout. False to log results.
+ *
* @return number of rows returned
* @throws Exception
*/
- public static int testRunAndPrint(
- final DrillClient drillClient, final QueryType type, final String
queryString) throws Exception {
+ private static int testRunAndOutput(final DrillClient drillClient,
+ final QueryType type,
+ final String queryString,
+ final boolean print) throws Exception {
final String query = normalizeQuery(queryString);
DrillConfig config = drillClient.getConfig();
AwaitableUserResultsListener resultListener =
- new AwaitableUserResultsListener(
- config.getBoolean(TEST_QUERY_PRINTING_SILENT) ?
- new SilentListener() :
- new PrintingResultsListener(config, Format.TSV,
VectorUtil.DEFAULT_COLUMN_WIDTH)
- );
+ new AwaitableUserResultsListener(print ?
+ new PrintingResultsListener(config, Format.TSV,
VectorUtil.DEFAULT_COLUMN_WIDTH):
+ new LoggingResultsListener(config, Format.TSV,
VectorUtil.DEFAULT_COLUMN_WIDTH));
drillClient.runQuery(type, query, resultListener);
return resultListener.await();
}
+ /**
+ * Execute one or more queries separated by semicolons, and output the
results.
+ *
+ * @param drillClient drill client to use
+ * @param queryString the query string
+ * @param print True to output results to stdout. False to log results.
+ * @throws Exception
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VectorUtil.showVectorAccessibleContent does not log vector content
> ------------------------------------------------------------------
>
> Key: DRILL-6496
> URL: https://issues.apache.org/jira/browse/DRILL-6496
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Arina Ielchiieva
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.14.0
>
>
> {{VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[]
> columnWidths)}} does not log vector content. Introduced after DRILL-6438.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
