[
https://issues.apache.org/jira/browse/DRILL-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547398#comment-16547398
]
ASF GitHub Bot commented on DRILL-6613:
---------------------------------------
paul-rogers commented on a change in pull request #1383: DRILL-6613: Refactor
MaterializedField
URL: https://github.com/apache/drill/pull/1383#discussion_r203252518
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ColumnState.java
##########
@@ -123,7 +123,7 @@ public static MapArrayColumnState
build(ResultSetLoaderImpl resultSetLoader,
// Create the map's offset vector.
UInt4Vector offsetVector = new UInt4Vector(
- BaseRepeatedValueVector.OFFSETS_FIELD,
+ MaterializedField.OFFSETS_FIELD,
Review comment:
While it is good idea to centralize these names, not sure the
`MaterializedField` is the place, since the metadata is logically a bit below
the level of vector structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor MaterializedField
> --------------------------
>
> Key: DRILL-6613
> URL: https://issues.apache.org/jira/browse/DRILL-6613
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
>
> {{MaterializedField}} does not need to implement {{clone()}} and should use
> constructor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
