[ 
https://issues.apache.org/jira/browse/DRILL-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Rudis updated DRILL-6611:
-----------------------------
    Description: 
The new ACE-based SQL query editor is great. Being able to submit the form 
without using a mouse would be even better.

Adding:

 
{noformat}
document.getElementById('queryForm')
 .addEventListener('keydown', function(e) {
 if (!(e.keyCode == 13 && e.metaKey)) return;
 if (e.target.form) doSubmitQueryWithUserName();
});
{noformat}
{{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such 
support.}}

I can file a PR with the code if desired.

------

Functionality (for the documentation):

This JIRA's commit introduces the following to Drill:

When composing queries in the web query editor it is now possible to submit the 
query text by using the {{Meta+Enter}} key combination. This will trigger the 
same action as pressing the {{Submit}} button. On Mac keyboards {{Meta+Enter}} 
is {{Cmd+Enter}}. On Windows or Linux is {{Ctrl+Enter}} though Linux users may 
have keymapped the {{Meta}} key to another physical keyboard key.

  was:
The new ACE-based SQL query editor is great. Being able to submit the form 
without using a mouse would be even better.

Adding:

 
{noformat}
document.getElementById('queryForm')
 .addEventListener('keydown', function(e) {
 if (!(e.keyCode == 13 && e.metaKey)) return;
 if (e.target.form) doSubmitQueryWithUserName();
});
{noformat}
{{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such 
support.}}

I can file a PR with the code if desired.


> Add [meta]-[Enter] js handler for query form submission
> -------------------------------------------------------
>
>                 Key: DRILL-6611
>                 URL: https://issues.apache.org/jira/browse/DRILL-6611
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.14.0
>            Reporter: Bob Rudis
>            Assignee: Bob Rudis
>            Priority: Minor
>              Labels: doc-impacting
>             Fix For: 1.15.0
>
>
> The new ACE-based SQL query editor is great. Being able to submit the form 
> without using a mouse would be even better.
> Adding:
>  
> {noformat}
> document.getElementById('queryForm')
>  .addEventListener('keydown', function(e) {
>  if (!(e.keyCode == 13 && e.metaKey)) return;
>  if (e.target.form) doSubmitQueryWithUserName();
> });
> {noformat}
> {{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such 
> support.}}
> I can file a PR with the code if desired.
> ------
> Functionality (for the documentation):
> This JIRA's commit introduces the following to Drill:
> When composing queries in the web query editor it is now possible to submit 
> the query text by using the {{Meta+Enter}} key combination. This will trigger 
> the same action as pressing the {{Submit}} button. On Mac keyboards 
> {{Meta+Enter}} is {{Cmd+Enter}}. On Windows or Linux is {{Ctrl+Enter}} though 
> Linux users may have keymapped the {{Meta}} key to another physical keyboard 
> key.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to