[
https://issues.apache.org/jira/browse/DRILL-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553254#comment-16553254
]
ASF GitHub Bot commented on DRILL-6611:
---------------------------------------
kkhatua commented on a change in pull request #1392: Implements DRILL-6611 to
enable meta-enter query submission in web query interface
URL: https://github.com/apache/drill/pull/1392#discussion_r204511759
##########
File path: exec/java-exec/src/main/resources/rest/query/query.ftl
##########
@@ -111,6 +111,12 @@
enableBasicAutocompletion: true,
enableLiveAutocompletion: false
});
+ // meta-enter to submit query
+ document.getElementById('queryForm')
+ .addEventListener('keydown', function(e) {
+ if (!(e.keyCode == 13 && e.metaKey)) return;
Review comment:
For Windows machines, the `metaKey` equivalent is the Windows key.
Interestingly, this is not supported by Firefox 48+ (Ref:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey )
For Windows, the key combination is `Ctrl+Enter` .
(https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/ctrlKey)
So, you'll need to do a check for the key events something like this:
```
if (! ((e.ctrlKey || e.metaKey) && e.keyCode == 13) ) return;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add [meta]-[Enter] js handler for query form submission
> -------------------------------------------------------
>
> Key: DRILL-6611
> URL: https://issues.apache.org/jira/browse/DRILL-6611
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.14.0
> Reporter: Bob Rudis
> Assignee: Bob Rudis
> Priority: Minor
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> The new ACE-based SQL query editor is great. Being able to submit the form
> without using a mouse would be even better.
> Adding:
>
> {noformat}
> document.getElementById('queryForm')
> .addEventListener('keydown', function(e) {
> if (!(e.keyCode == 13 && e.metaKey)) return;
> if (e.target.form) doSubmitQueryWithUserName();
> });
> {noformat}
> {{to ./exec/java-exec/src/main/resources/rest/query/query.ftl adds such
> support.}}
> I can file a PR with the code if desired.
> ------
> Functionality (for the documentation):
> This JIRA's commit introduces the following to Drill:
> When composing queries in the web query editor it is now possible to submit
> the query text by using the {{Meta+Enter}} key combination. This will trigger
> the same action as pressing the {{Submit}} button. On Mac keyboards
> {{Meta+Enter}} is {{Cmd+Enter}}. On Windows or Linux is {{Ctrl+Enter}} though
> Linux users may have keymapped the {{Meta}} key to another physical keyboard
> key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
