[ 
https://issues.apache.org/jira/browse/DRILL-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562153#comment-16562153
 ] 

ASF GitHub Bot commented on DRILL-6616:
---------------------------------------

HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch 
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r206249771
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
 ##########
 @@ -317,6 +319,33 @@ public Void visitCall(RexCall call) {
     }
   }
 
+  /**
+   * Given a list of rexnodes it transforms the rexnodes by changing the expr 
to use new index mapped to the old index.
+   * @param builder : RexBuilder from the planner.
+   * @param exprs: RexNodes to be transformed.
+   * @param corrMap: Mapping between old index to new index.
+   * @return
+   */
+  public static List<RexNode> transformExprs(RexBuilder builder, List<RexNode> 
exprs, Map<Integer, Integer> corrMap) {
 
 Review comment:
   AFAIK, calcite does something like this but it is done in a private method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Batch Processing for Lateral/Unnest
> -----------------------------------
>
>                 Key: DRILL-6616
>                 URL: https://issues.apache.org/jira/browse/DRILL-6616
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>    Affects Versions: 1.14.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>            Priority: Major
>             Fix For: 1.15.0
>
>
> Implement the execution and planner side changes for the batch processing 
> done by lateral and unnest. Based on the prototype we found performance to be 
> much better as compared to initial row-by-row execution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to