[
https://issues.apache.org/jira/browse/DRILL-6640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567667#comment-16567667
]
ASF GitHub Bot commented on DRILL-6640:
---------------------------------------
HanumathRao commented on a change in pull request #1405: DRILL-6640: Modifying
DotDrillUtil implementation to avoid using globStatus calls
URL: https://github.com/apache/drill/pull/1405#discussion_r207419304
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/dotdrill/TestDotDrillUtil.java
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.dotdrill;
+
+import java.util.List;
+
+import static org.junit.Assert.assertTrue;
+
+import org.apache.drill.exec.store.dfs.DrillFileSystem;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class TestDotDrillUtil {
+
+ private static final String TEST_ROOT_DIR =
System.getProperty("java.io.tmpdir") + "/dot_drill_util";
Review comment:
I think you may want to look at some existing tests to inherit baseclass
like BaseTestQuery. This will make sure that the test directories are cleaned
up properly.
@ilooner Can you please take a look at the test file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Drill takes long time in planning when there are large number of files in
> views/tables DFS parent directory
> ------------------------------------------------------------------------------------------------------------
>
> Key: DRILL-6640
> URL: https://issues.apache.org/jira/browse/DRILL-6640
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Reporter: Arjun
> Assignee: Arjun
> Priority: Major
> Fix For: 1.15.0
>
>
> When Drill is used for querying views/ tables, the query planning time
> increases as the number of files in views/tables parent directory increases.
> This becomes unacceptably long with complex queries.
> This is caused by globStatus operation on view files using GLOB to retrieve
> view file status. This can be improved by avoiding the usage of GLOB pattern
> for Drill metadata files like view files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
