[
https://issues.apache.org/jira/browse/DRILL-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572590#comment-16572590
]
ASF GitHub Bot commented on DRILL-6656:
---------------------------------------
ilooner commented on a change in pull request #1415: DRILL-6656: Disallow extra
semicolons in import statements.
URL: https://github.com/apache/drill/pull/1415#discussion_r208441905
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java
##########
@@ -93,13 +93,13 @@ public boolean isAggregating() {
//Loop through all workspace vectors, to get the minimum of size of
all workspace vectors.
JVar sizeVar = setupBlock.decl(g.getModel().INT, "vectorSize",
JExpr.lit(Integer.MAX_VALUE));
JClass mathClass = g.getModel().ref(Math.class);
- for (int id = 0; id < getWorkspaceVars().length; id ++) {
+ for (int id = 0; id < getWorkspaceVars().length; id++) {
if (!getWorkspaceVars()[id].isInject()) {
setupBlock.assign(sizeVar,mathClass.staticInvoke("min").arg(sizeVar).arg(g.getWorkspaceVectors().get(getWorkspaceVars()[id]).invoke("getValueCapacity")));
}
}
- for(int i =0 ; i < getWorkspaceVars().length; i++) {
+ for(int i =0; i < getWorkspaceVars().length; i++) {
Review comment:
@vvysotskyi Updated the PR. I tried fixing any other style issues i saw with
the lines I modified. Please see the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Regex To Disallow Extra Semicolons In Imports
> -------------------------------------------------
>
> Key: DRILL-6656
> URL: https://issues.apache.org/jira/browse/DRILL-6656
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.15.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
