[ https://issues.apache.org/jira/browse/DRILL-6656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575410#comment-16575410 ]
ASF GitHub Bot commented on DRILL-6656: --------------------------------------- ilooner commented on a change in pull request #1415: DRILL-6656: Disallow extra semicolons in import statements. URL: https://github.com/apache/drill/pull/1415#discussion_r209085506 ########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java ########## @@ -713,7 +713,7 @@ public void eval() { if (length.value > 0) { charLen = Math.min((int)length.value, charCount); //left('abc', 5) -> 'abc' } else if (length.value < 0) { - charLen = Math.max(0, charCount + (int)length.value) ; // left('abc', -5) ==> '' + charLen = Math.max(0, charCount + (int)length.value); // left('abc', -5) ==> '' Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Regex To Disallow Extra Semicolons In Imports > ------------------------------------------------- > > Key: DRILL-6656 > URL: https://issues.apache.org/jira/browse/DRILL-6656 > Project: Apache Drill > Issue Type: Improvement > Reporter: Timothy Farkas > Assignee: Timothy Farkas > Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)