[
https://issues.apache.org/jira/browse/DRILL-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602896#comment-16602896
]
ASF GitHub Bot commented on DRILL-6724:
---------------------------------------
KazydubB commented on issue #1455: DRILL-6724: Convert IndexOutOfBounds
exception to UserException with …
URL: https://github.com/apache/drill/pull/1455#issuecomment-418324098
@paul-rogers, source of IOBE here is when allocating value vector buffers or
reading records from input. Currently, every Exception (except
OutOfMemoryException and UserException) will be wrapped into UserException with
ErrorType INTERNAL_ERROR (and will remain being such after FragmentExecutor
handling).
Purpose of this improvement is to enhance error messages to provide more
useful information to users, while original cause is preserved. Provided
context may be useful for users as it may provide some ways of resolving the
issue or to make a workaround while the issue is being investigated etc.
You're right that IOBE indicates a program error so I've made changes to
wrap IOBE into UserException of type INTERNAL_ERROR and not DATA_READ_ERROR (as
it was before in the PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Convert IndexOutOfBounds exception to UserException with context data where
> possible
> ------------------------------------------------------------------------------------
>
> Key: DRILL-6724
> URL: https://issues.apache.org/jira/browse/DRILL-6724
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.14.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.15.0
>
>
> Sometimes when IndexOutOfBoundsException is exposed to users it is not clear
> what causes the problem. Instead this exception may be converted to a more
> useful UserException containing context data like filename, line, position
> etc (depending on what is available from a reader for a given type).
> A possible approach is to add a method to a RecordReader interface which
> produces UserException of type ErrorType.DATA_READ with context data, so that
> when such an UserException is needed it can be easily obtained by invoking
> the method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
